Hi @gmatheus
Thx for your PR 👍 !
Just one question : i guess with your changes, the plugin can't be updated for previous version of kibana ?

@tcharlot-datasweet That's right. This is mainly because Elastic team updated the plugin development scripts since Kibana 6.3. The plugin-helpers dependency is now a package inside ../../kibana/packages, so, to run/build the project, you must have an updated Kibana copy inside parent folder.

They also removed some Angular services and changed some classes from Kibana source code, so we had to refactor some imports (just as you did in the first commit of this PR). In the long term, this can generate a lot of conditional-versioning logic in the code.

If you organize plugin releases versions as I mentioned above, sometimes you can backport a feature or bugfix through versions. Example:

• Imagine you have master branch and v1.1.x branch. Master is for Kibana 6.4.x and v1.1.x branch is for Kibana 5.6.x ~ 6.3.x versions.
• Some bugfix is pushed to master. You can backport it if needed:

git checkout v1.1.x
git cherry-pick <commit from master>

This applies the bugfix commit from master into v1.1.x branch!

If your team depends directly on previous versions of Kibana, you can do the opposite: set the master branch to point to the current version of plugin and create a new branch to handle 6.4.x version and future updates. In this case, this PR should target your 6.4.x branch instead of master. What do you think?

Hi @gmatheus
Can u fix your PR ? I will create a new branch v1 for old kibana (<= 6.3.x) and merge your changes into master.
Thx for your time 👍

@tcharlot-datasweet Conflicts resolved! Please wait a little bit to merge this one, I just noticed an error while using the Formula Plugin with "other values" feature (from terms bucket aggregation):

I'll try to fix this in the next days!

Ok 👍
Thx :)

Just realized this is not a plugin-related bug (see this issue), so I guess we're ready merge this PR!

@tcharlot-datasweet , do you plan to merge this PR and release it soon? We migrated Kibana to 6.4 and datasweet plugin is not working now. It would be very helpful if this fix releases. Thanks in advance and great work!

We installed the latest update and it works now. Really appreciate it!